Add recursive structs supported #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrwiersma
requested changes
Dec 21, 2023
* 'main' of github.com:RyougiNevermore/avro: add processing group
|
I'm not sure about the results of golangci-lint. any help? |
* origin/main: feat: move generic decoding to codec level (hamba#336) fix: linter issues # Conflicts: # config.go
TestEncoder_RecordMapNilValue passed
|
uhhh, if support disable cache mode, maybe use some one like ctx, and it will cost more performance, from 1400 ns/op up to 1700 ns/op in. |
nrwiersma
requested changes
Jan 12, 2024
| } | ||
|
|
||
| type processingGroup struct { | ||
| group *singleflight.Group |
There was a problem hiding this comment.
This is not needed for the local option.
| type encoderOfTypeHandler func(cfg *frozenConfig, p *processing, schema Schema, typ reflect2.Type) ValEncoder | ||
|
|
||
| type processing struct { | ||
| key []byte |
There was a problem hiding this comment.
I dont get what this is used for?
| @@ -0,0 +1,46 @@ | |||
| // Package mmhash export runtime.memhash | |||
| package mmhash | |||
|
Fixed by #413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just use processing cache, and no performance loss.